jojochuang commented on code in PR #6413:
URL: https://github.com/apache/ozone/pull/6413#discussion_r1532759068
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/CommitWatcher.java:
##########
@@ -81,10 +80,10 @@ public void putFlushFuture(long flushPos,
CompletableFuture<ContainerCommandResp
}
- public void waitOnFlushFutures() throws InterruptedException,
ExecutionException {
- // wait for all the transactions to complete
- CompletableFuture.allOf(futureMap.values().toArray(
- new CompletableFuture[0])).get();
+ public CompletableFuture<Void> waitOnFlushFutures() {
Review Comment:
it doesn't wait; rename this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
