errose28 commented on code in PR #6360:
URL: https://github.com/apache/ozone/pull/6360#discussion_r1540222586
##########
hadoop-hdds/docs/content/interface/ReconApi.md:
##########
@@ -927,6 +927,39 @@ Returns all the datanodes in the cluster.
]
}
```
+
+### PUT /api/v1/datanodes/remove
Review Comment:
We have a swagger API spec for Recon we should update too right?
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java:
##########
@@ -88,6 +88,10 @@
*/
public class NodeStateManager implements Runnable, Closeable {
+ public void removeNode(DatanodeDetails datanodeDetails) throws
NodeNotFoundException {
+ nodeStateMap.removeNode(datanodeDetails);
+ }
+
Review Comment:
I think we should avoid adding anything that could affect SCM. I can see
someone doing an SCM change and incorrectly calling this method when it will
probably do something incorrect in that context. I know the Recon/SM
inheritance model makes this tricky, but can we either keep these changes out
of SCM, or make sure that they work equally as well in an SCM context (if we
were to add a remove node command to SCM in the future, for example).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
