sumitagrawl commented on code in PR #6360:
URL: https://github.com/apache/ozone/pull/6360#discussion_r1540575910
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java:
##########
@@ -88,6 +88,10 @@
*/
public class NodeStateManager implements Runnable, Closeable {
+ public void removeNode(DatanodeDetails datanodeDetails) throws
NodeNotFoundException {
+ nodeStateMap.removeNode(datanodeDetails);
+ }
+
Review Comment:
@devmadhuu We need define completeness of node removal. If some action to be
taken before calling, we can have comment for the clarity.
- Pre-condition which needs to be happen before removal of node like
resources to be removed like pipelines, containers, network topology, or any
other cache before calling this
- Removal of all related information within NodeManager context
We can give some reference like DeadNodeHandler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
