sumitagrawl commented on code in PR #6360:
URL: https://github.com/apache/ozone/pull/6360#discussion_r1540787126
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconNodeManager.java:
##########
@@ -321,4 +321,18 @@ public long getNodeDBKeyCount() throws IOException {
return nodeCount;
}
}
+
+ /**
+ * Remove an existing node from the NodeDB. Explicit removal from admin user.
+ * First this API call removes the node info from NodeManager memory and
+ * if successful, then remove the node finally from NODES table as well.
+ *
+ * @param datanodeDetails Datanode details.
+ * @throws IOException, NodeNotFoundException
+ */
+ public void removeNode(DatanodeDetails datanodeDetails) throws IOException,
NodeNotFoundException {
+ getNodeStateManager().removeNode(datanodeDetails);
Review Comment:
IMO, first can remove from Db and then from cache, so that if db update
fails, operation can be retried to remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
