smengcl commented on code in PR #6573:
URL: https://github.com/apache/ozone/pull/6573#discussion_r1577020454
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockOutputStream.java:
##########
@@ -305,24 +305,24 @@ void testWriteExactlyFlushSize(boolean flushDelay) throws
Exception {
assertEquals(1, keyOutputStream.getStreamEntries().size());
// The previously written data is equal to flushSize, so no action is
// triggered when execute flush, if flushDelay is enabled.
- assertEquals(pendingWriteChunkCount + (flushDelay ? 2 : 0),
- metrics.getPendingContainerOpCountMetrics(WriteChunk));
- assertEquals(pendingPutBlockCount + (flushDelay ? 1 : 0),
- metrics.getPendingContainerOpCountMetrics(PutBlock));
+ if (!flushDelay) {
Review Comment:
Thanks @chungen0126 for the patch.
Would you mind putting a paragraph of brief explanation in the PR
description on how this test was broken, and especially why the following
checks should be skipped when `flushDelay == true`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
