adoroszlai commented on code in PR #6573:
URL: https://github.com/apache/ozone/pull/6573#discussion_r1580731129
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockOutputStream.java:
##########
@@ -305,24 +305,24 @@ void testWriteExactlyFlushSize(boolean flushDelay) throws
Exception {
assertEquals(1, keyOutputStream.getStreamEntries().size());
// The previously written data is equal to flushSize, so no action is
// triggered when execute flush, if flushDelay is enabled.
- assertEquals(pendingWriteChunkCount + (flushDelay ? 2 : 0),
- metrics.getPendingContainerOpCountMetrics(WriteChunk));
- assertEquals(pendingPutBlockCount + (flushDelay ? 1 : 0),
- metrics.getPendingContainerOpCountMetrics(PutBlock));
+ if (!flushDelay) {
Review Comment:
@chungen0126 Let me clarify my comment. The test has been passing without
intermittent failures for a long time. Some change in either Ozone production
code or the test environment must have triggered the failures. We need to find
this change. I could be wrong, but I suspect it was 2f05353940 (committed Mar
6), which introduced multi-threaded execution in `BlockOutputStream` response
processing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
