adoroszlai commented on code in PR #6573:
URL: https://github.com/apache/ozone/pull/6573#discussion_r1580667322
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockOutputStream.java:
##########
@@ -305,24 +305,24 @@ void testWriteExactlyFlushSize(boolean flushDelay) throws
Exception {
assertEquals(1, keyOutputStream.getStreamEntries().size());
// The previously written data is equal to flushSize, so no action is
// triggered when execute flush, if flushDelay is enabled.
- assertEquals(pendingWriteChunkCount + (flushDelay ? 2 : 0),
- metrics.getPendingContainerOpCountMetrics(WriteChunk));
- assertEquals(pendingPutBlockCount + (flushDelay ? 1 : 0),
- metrics.getPendingContainerOpCountMetrics(PutBlock));
+ if (!flushDelay) {
Review Comment:
Sorry, I missed the comment added in the code, was looking for it in the PR
(or Jira) description.
However,
> If flushDelay is disabled, it will call waitOnFlushFutures to wait all
putBlocks finished.
I don't think that explains why the test started failing suddenly around Mar
15, 2024 (see list of failures in HDDS-10557). Last non-trivial change was
493c90066f on Dec 15, 2023.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
