Montura commented on PR #6577: URL: https://github.com/apache/ozone/pull/6577#issuecomment-2076469283
> > * A command like `ozone admin pipeline close --replication=EC 1` will close pipeline 1 even if it is a Ratis pipeline. > > * It would be good to disallow the pipeline filter options when ID is specified, but I'm not sure how easy that is to do with pico CLI. * Befor my changes `ozone admin pipeline close PIPELINE_ID` was working only for specified `PIPELINE_ID`, so when user provides `PIPELINE_ID` he knows it's _replicataion factor_ and _replication type_. There were no filters for this command. * Filters for replication type and factor appiled only for `ozone admin pipeline list --filters` command. * I thought that it would be nice to add the same filter option when run `ozone admin pipeline close --all` to be able to close only `EC` or only `RATIS` pipelines for example. So, I'm confused a bit about adding any filters for closing pipeline by ID. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
