errose28 commented on code in PR #6577:
URL: https://github.com/apache/ozone/pull/6577#discussion_r1583761758
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/pipeline/ClosePipelineSubcommand.java:
##########
@@ -51,7 +51,7 @@ public class ClosePipelineSubcommand extends ScmSubcommand {
public void execute(ScmClient scmClient) throws IOException {
if (!Strings.isNullOrEmpty(closeOption.pipelineId)) {
if (filterOptions.getReplicationFilter().isPresent()) {
- System.out.println("When close pipeline by ID filters are ignored.");
+ System.err.println("Replication filters can only be used with --all");
Review Comment:
Sorry if the last comment was not clear. We should also fail the command
here instead of closing the pipeline anyways since the user did something
invalid. We can probably throw `IllegalArgumentException` like
`FilterPipelineOptions#getReplicationFilter` does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
