errose28 commented on code in PR #6577:
URL: https://github.com/apache/ozone/pull/6577#discussion_r1594845672
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/pipeline/ClosePipelineSubcommand.java:
##########
@@ -51,7 +51,7 @@ public class ClosePipelineSubcommand extends ScmSubcommand {
public void execute(ScmClient scmClient) throws IOException {
if (!Strings.isNullOrEmpty(closeOption.pipelineId)) {
if (filterOptions.getReplicationFilter().isPresent()) {
- System.out.println("When close pipeline by ID filters are ignored.");
+ System.err.println("Replication filters can only be used with --all");
Review Comment:
I just tried all three of these to double check and option 3 is what we
want. There is logic farther up to print just the message to stderr and not the
stack trace. Option 2 will print the message twice. Option 1 will exit 0 when
it should exit nonzero.
Just looking at the example you provided I think cert.InfoSubcommand might
print the message twice as well, but I did not try it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
