fapifta commented on code in PR #6725:
URL: https://github.com/apache/ozone/pull/6725#discussion_r1630860112
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMSecurityProtocolServer.java:
##########
@@ -439,20 +424,18 @@ public String getCACertificate() throws IOException {
}
/**
- *
- * @param role - node role: OM/SCM/DN.
- * @param startSerialId - start certificate serial id.
- * @param count - max number of certificates returned in a batch.
- * @param isRevoked - whether list for revoked certs only.
+ * @param role - node role: OM/SCM/DN.
+ * @param startSerialId - start certificate serial id.
+ * @param count - max number of certificates returned in a batch.
* @return
* @throws IOException
*/
@Override
public List<String> listCertificate(NodeType role,
- long startSerialId, int count, boolean isRevoked) throws IOException {
+ long startSerialId, int count) throws IOException {
List<X509Certificate> certificates =
- scmCertificateServer.listCertificate(role, startSerialId, count,
- isRevoked);
+ scmCertificateServer.listCertificate(role, startSerialId, count
+ );
Review Comment:
you are right, thank you for spotting this one...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
