fapifta commented on code in PR #6725:
URL: https://github.com/apache/ozone/pull/6725#discussion_r1633274846
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/report/TestReportPublisher.java:
##########
@@ -182,66 +170,4 @@ public void testCommandStatusPublisher() throws
InterruptedException {
"Should publish report with 2 status objects");
executorService.shutdown();
}
-
- @Test
- public void testCRLStatusReportPublisher() throws IOException {
- StateContext dummyContext = mock(StateContext.class);
- DatanodeStateMachine dummyStateMachine =
- mock(DatanodeStateMachine.class);
- ReportPublisher publisher = new CRLStatusReportPublisher();
- DatanodeCRLStore dnCrlStore = mock(DatanodeCRLStore.class);
- when(dnCrlStore.getLatestCRLSequenceID()).thenReturn(3L);
- List<CRLInfo> pendingCRLs = new ArrayList<>();
- pendingCRLs.add(mock(CRLInfo.class));
- pendingCRLs.add(mock(CRLInfo.class));
- when(dnCrlStore.getPendingCRLs()).thenReturn(pendingCRLs);
- when(dummyStateMachine.getDnCRLStore()).thenReturn(dnCrlStore);
- when(dummyContext.getParent()).thenReturn(dummyStateMachine);
- publisher.setConf(config);
-
- ScheduledExecutorService executorService = HadoopExecutors
- .newScheduledThreadPool(1,
- new ThreadFactoryBuilder().setDaemon(true)
- .setNameFormat("TestReportManagerThread-%d").build());
- publisher.init(dummyContext, executorService);
- Message report =
- ((CRLStatusReportPublisher) publisher).getReport();
- assertNotNull(report);
- for (Descriptors.FieldDescriptor descriptor :
- report.getDescriptorForType().getFields()) {
- if (descriptor.getNumber() ==
- CRLStatusReport.RECEIVEDCRLID_FIELD_NUMBER) {
- assertEquals(3L, report.getField(descriptor));
- }
- }
- executorService.shutdown();
- }
-
- /**
- * Get a datanode details.
- *
- * @return DatanodeDetails
- */
- private static DatanodeDetails getDatanodeDetails() {
Review Comment:
yes, however I think it does worth to remove it right now, and do not
separate it to an other PR if I already touch this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
