fapifta commented on code in PR #6725:
URL: https://github.com/apache/ozone/pull/6725#discussion_r1633270464
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/TestHddsDatanodeService.java:
##########
@@ -106,22 +103,6 @@ public void setUp() throws IOException {
conf.set(DFSConfigKeysLegacy.DFS_DATANODE_DATA_DIR_KEY, volumeDir);
}
- @Test
- public void testStartup() {
- service.start(conf);
-
- assertNotNull(service.getDatanodeDetails());
- assertNotNull(service.getDatanodeDetails().getHostName());
- assertFalse(service.getDatanodeStateMachine().isDaemonStopped());
- assertNotNull(service.getCRLStore());
-
- service.stop();
- // CRL store must be stopped when the service stops
- assertNull(service.getCRLStore().getStore());
Review Comment:
Hi @dombizita,
first I just removed the CRL related part, then I took a look at the
testcase, and found that it calls only the start, and stop method of the
HDDSDataNodeService class, and in between it does 3 assertions:
1. the DatanodeDetails is not null
2. the DatanodeDetails contains a hostname that is not null
3. the Datanode's statemachine is not stopped.
From these three assertions, none seems to be useful as if these assertions
are not correct, then something should fail separately as these as far as I can
tell fundamental things that are needed for normal operations also, so as a
last resort our docker based tests should fail on read and write operations if
these assertions are not true, hence I propose to remove the remaining part of
the test also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
