fapifta commented on code in PR #6725:
URL: https://github.com/apache/ozone/pull/6725#discussion_r1633501277
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/TestHddsDatanodeService.java:
##########
@@ -106,22 +103,6 @@ public void setUp() throws IOException {
conf.set(DFSConfigKeysLegacy.DFS_DATANODE_DATA_DIR_KEY, volumeDir);
}
- @Test
- public void testStartup() {
- service.start(conf);
-
- assertNotNull(service.getDatanodeDetails());
- assertNotNull(service.getDatanodeDetails().getHostName());
- assertFalse(service.getDatanodeStateMachine().isDaemonStopped());
- assertNotNull(service.getCRLStore());
-
- service.stop();
- // CRL store must be stopped when the service stops
- assertNull(service.getCRLStore().getStore());
Review Comment:
Though, looking at it once more, I think it is best to move these three
assertions to the test that remains in this class, just to be sure, I hope you
are fine with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
