siddhantsangwan commented on code in PR #7155:
URL: https://github.com/apache/ozone/pull/7155#discussion_r1749942200
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeDecommissionManager.java:
##########
@@ -431,8 +435,9 @@ private synchronized boolean
checkIfDecommissionPossible(List<DatanodeDetails> d
int reqNodes = cif.getReplicationConfig().getRequiredNodes();
if ((inServiceTotal - numDecom) < reqNodes) {
String errorMsg = "Insufficient nodes. Tried to decommission " +
dns.size() +
- " nodes of which " + numDecom + " nodes were valid. Cluster
has " + inServiceTotal +
- " IN-SERVICE nodes, " + reqNodes + " of which are required for
minimum replication. ";
+ " nodes out of " + inServiceTotal + " IN-SERVICE HEALTHY and "
+ unHealthyTotal +
+ " UNHEALTHY nodes. Cannot decommission as a minimum of " +
reqNodes +
Review Comment:
Yes, your latest comment is what I meant as well. I agree. One way to get
unhealthyTotal is what I commented earlier -
https://github.com/apache/ozone/pull/7155#discussion_r1745951180.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
