VarshaRaviCV commented on code in PR #7155:
URL: https://github.com/apache/ozone/pull/7155#discussion_r1751589935
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeDecommissionManager.java:
##########
@@ -391,17 +391,21 @@ private synchronized boolean
checkIfDecommissionPossible(List<DatanodeDetails> d
int numDecom = dns.size();
List<DatanodeDetails> validDns = new ArrayList<>(dns);
int inServiceTotal =
nodeManager.getNodeCount(NodeStatus.inServiceHealthy());
+ int unHealthyTotal = nodeManager.getNodeCount(NodeStatus.inServiceStale())
+
+ nodeManager.getNodeCount(NodeStatus.inServiceDead());
for (DatanodeDetails dn : dns) {
try {
NodeStatus nodeStatus = getNodeStatus(dn);
NodeOperationalState opState = nodeStatus.getOperationalState();
if (opState != NodeOperationalState.IN_SERVICE) {
numDecom--;
validDns.remove(dn);
+ LOG.warn("Cannot decommission " + dn.getHostName() + " because it is
not IN-SERVICE");
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
