slfan1989 commented on code in PR #7206:
URL: https://github.com/apache/ozone/pull/7206#discussion_r1767333268
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java:
##########
@@ -303,15 +304,17 @@ public void start() {
datanodeDetails.setPort(DatanodeDetails.newPort(HTTPS,
httpServer.getHttpsAddress().getPort()));
}
+
serviceRuntimeInfo.setHttpPort(String.valueOf(httpServer.getHttpAddress().getPort()));
} catch (Exception ex) {
LOG.error("HttpServer failed to start.", ex);
}
-
clientProtocolServer = new HddsDatanodeClientProtocolServer(
datanodeDetails, conf, HddsVersionInfo.HDDS_VERSION_INFO,
reconfigurationHandler);
+
serviceRuntimeInfo.setRpcPort(String.valueOf(clientProtocolServer.getClientRpcAddress().getPort()));
Review Comment:
Thank you very much for your question!
I hope to present the RPC port needed for client connections, which might be
more appropriately named `ClientRpcPort`. I should add some comments to make
the code clearer.
- `OM` displays the `RpcPort (9862)` in JMX.
https://github.com/apache/ozone/blob/d3899d2cc3912fe47314a6af0c7bceee89114789/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMXBean.java#L28-L33
- `SCM` currently displays `DatanodeRpcPort (9861)` and `ClientRpcPort
(9860)` in JMX.
https://github.com/apache/ozone/blob/d3899d2cc3912fe47314a6af0c7bceee89114789/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMMXBean.java#L34-L50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
