slfan1989 commented on code in PR #7206:
URL: https://github.com/apache/ozone/pull/7206#discussion_r1767340818
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java:
##########
@@ -303,15 +304,17 @@ public void start() {
datanodeDetails.setPort(DatanodeDetails.newPort(HTTPS,
httpServer.getHttpsAddress().getPort()));
}
+
serviceRuntimeInfo.setHttpPort(String.valueOf(httpServer.getHttpAddress().getPort()));
Review Comment:
You are correct. we should add the corresponding port metric for `HTTPS`. As
for the `hostname`, I believe we can have `HTTP` and `HTTPS` share the same
one, since they are theoretically consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
