slfan1989 commented on code in PR #7206:
URL: https://github.com/apache/ozone/pull/7206#discussion_r1832201100
##########
hadoop-hdds/container-service/src/main/resources/webapps/hddsDatanode/dn-overview.html:
##########
@@ -22,8 +22,28 @@
</tbody>
</table>
+<h2>HeartBeat Information</h2>
+<table class="table" class="col-md-6">
+ <thead>
+ <tr>
+ <th>Address</th>
+ <th>Last Successful HeartBeat</th>
+ <th>Missed Count</th>
+ <th>State</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr ng-repeat="scm in $ctrl.dnmetrics2[0].SCMServers">
+ <td>{{scm.addressString}}</td>
+ <td>{{scm.lastSuccessfulHeartbeat}}</td>
+ <td>{{scm.missedCount}}</td>
+ <td>{{scm.state}}</td>
+ </tr>
+ </tbody>
+</table>
+
<h2>Volume Information</h2>
-<table class="table table-bordered table-striped" class="col-md-6">
Review Comment:
After completing the heartbeat table, I noticed that the table might look
better without borders, so I removed the table borders. Do you agree with this
change?
The modified table has the following style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
