slfan1989 commented on code in PR #7206:
URL: https://github.com/apache/ozone/pull/7206#discussion_r1832210175
##########
hadoop-hdds/framework/src/main/resources/webapps/static/ozone.js:
##########
@@ -48,8 +48,13 @@
});
angular.module('ozone').component('jvmParameters', {
templateUrl: 'static/templates/jvm.html',
- controller: function($http) {
+ controller: function($http, $scope) {
var ctrl = this;
+
+ $scope.toggleContent = function() {
+ $scope.contentVisible = !$scope.contentVisible;
Review Comment:
The initial value of `$scope.contentVisible` should be false, as this
variable controls whether the JVM page expands to show detailed configuration.
I believe we should assign an initial value to this variable to make the code
more standardized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
