sadanand48 commented on code in PR #7434:
URL: https://github.com/apache/ozone/pull/7434#discussion_r1843234848
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -624,7 +625,12 @@ public ReferenceCounted<IOmMetadataReader>
getActiveFsMetadataOrSnapshot(
String[] keyParts = keyName.split(OM_KEY_PREFIX);
if (isSnapshotKey(keyParts)) {
String snapshotName = keyParts[1];
-
+ // Updating the volumeName & bucketName in case the bucket is a linked
bucket. We need to do this before a
Review Comment:
The method above this "deleteKeysFromDelKeyTableInSnapshotScope" also needs
correction. Or are we planning to handle garbage collection separately?
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOmSnapshot.java:
##########
@@ -228,10 +238,21 @@ private void init() throws Exception {
// stop the deletion services so that keys can still be read
stopKeyManager();
- preFinalizationChecks();
+// preFinalizationChecks();
Review Comment:
Is this intentional? why did we comment this out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
