sumitagrawl commented on code in PR #7434:
URL: https://github.com/apache/ozone/pull/7434#discussion_r1843419693
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java:
##########
@@ -106,7 +108,11 @@ public OMRequest preExecute(OzoneManager ozoneManager)
throws IOException {
final OMRequest omRequest = super.preExecute(ozoneManager);
// Verify name
OmUtils.validateSnapshotName(snapshotName);
-
+ // Updating the volumeName & bucketName in case the bucket is a linked
bucket. We need to do this before a
+ // permission check, since linked bucket permissions and source bucket
permissions could be different.
+ ResolvedBucket bucket = ozoneManager.resolveBucketLink(Pair.of(volumeName,
bucketName), this);
Review Comment:
We can more opinion if really need support this, as it will increase
un-necessary load without knowing actual information at backend (if its linked).
No one will be interested in doing multiple snapshot creation for linked
directory ... can use actual bucket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
