swamirishi commented on code in PR #7434:
URL: https://github.com/apache/ozone/pull/7434#discussion_r1843792018


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java:
##########
@@ -106,7 +108,11 @@ public OMRequest preExecute(OzoneManager ozoneManager) 
throws IOException {
     final OMRequest omRequest = super.preExecute(ozoneManager);
     // Verify name
     OmUtils.validateSnapshotName(snapshotName);
-
+    // Updating the volumeName & bucketName in case the bucket is a linked 
bucket. We need to do this before a
+    // permission check, since linked bucket permissions and source bucket 
permissions could be different.
+    ResolvedBucket bucket = ozoneManager.resolveBucketLink(Pair.of(volumeName, 
bucketName), this);

Review Comment:
   That is not necessary case. Consider the case I have a use case for multiple 
snapshots to preserve a state of the multiple tables on separate instances and 
I intend to run some jobs on top of these snapshotted of tables at the same 
time. I intend to do take a snapshot on the planning stage of the job and 
intend to delete on cleanup once the job finishes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to