smengcl commented on code in PR #7446:
URL: https://github.com/apache/ozone/pull/7446#discussion_r1845334259
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -628,7 +628,7 @@ public ReferenceCounted<IOmMetadataReader>
getActiveFsMetadataOrSnapshot(
// Updating the volumeName & bucketName in case the bucket is a linked
bucket. We need to do this before a
// permission check, since linked bucket permissions and source bucket
permissions could be different.
ResolvedBucket resolvedBucket =
ozoneManager.resolveBucketLink(Pair.of(volumeName,
- bucketName), false);
+ bucketName), false, false);
Review Comment:
Thanks @swamirishi for the patch.
As long as we make sure `getActiveFsMetadataOrSnapshot()` can ONLY be called
by a privileged user that has admin permission, I am good with this. According
to your updated PR description that seems to be the case here.
Because otherwise it becomes a potential security hole (info leak).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
