hemantk-12 commented on code in PR #7446:
URL: https://github.com/apache/ozone/pull/7446#discussion_r1847412953
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -628,7 +628,7 @@ public ReferenceCounted<IOmMetadataReader>
getActiveFsMetadataOrSnapshot(
// Updating the volumeName & bucketName in case the bucket is a linked
bucket. We need to do this before a
// permission check, since linked bucket permissions and source bucket
permissions could be different.
ResolvedBucket resolvedBucket =
ozoneManager.resolveBucketLink(Pair.of(volumeName,
- bucketName), false);
+ bucketName), false, false);
Review Comment:
Please update the above comment since we are skipping ACL check now.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -4442,7 +4459,8 @@ private OmBucketInfo resolveBucketLink(
UserGroupInformation userGroupInformation,
InetAddress remoteAddress,
String hostName,
- boolean allowDanglingBuckets) throws IOException {
+ boolean allowDanglingBuckets,
+ boolean aclEnabled) throws IOException {
Review Comment:
nit: `aclEnabled` and other parameters are not present in the java-doc
comment. Please update it accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
