hemantk-12 commented on code in PR #7446:
URL: https://github.com/apache/ozone/pull/7446#discussion_r1847398471
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -4416,15 +4422,26 @@ public ResolvedBucket resolveBucketLink(Pair<String,
String> requested,
ugi,
remoteIp != null ? remoteIp : omRpcAddress.getAddress(),
remoteIp != null ? remoteIp.getHostName() :
- omRpcAddress.getHostName(), allowDanglingBuckets);
+ omRpcAddress.getHostName(), allowDanglingBuckets, aclEnabled);
} else {
resolved = resolveBucketLink(requested, new HashSet<>(),
- null, null, null, allowDanglingBuckets);
+ null, null, null, allowDanglingBuckets, aclEnabled);
}
return new ResolvedBucket(requested.getLeft(), requested.getRight(),
resolved);
}
+ private OmBucketInfo resolveBucketLink(
+ Pair<String, String> volumeAndBucket,
+ Set<Pair<String, String>> visited,
+ UserGroupInformation userGroupInformation,
+ InetAddress remoteAddress,
+ String hostName,
+ boolean allowDanglingBuckets) throws IOException {
+ return resolveBucketLink(volumeAndBucket, visited, userGroupInformation,
remoteAddress, hostName,
+ allowDanglingBuckets, isAclEnabled);
+ }
Review Comment:
What's the usage of this function? `aclEnabled` is class variable, why do
you need to pass it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
