JingsongLi commented on code in PR #1261:
URL: https://github.com/apache/incubator-paimon/pull/1261#discussion_r1222478103
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlSyncDatabaseAction.java:
##########
@@ -105,6 +110,10 @@ public class MySqlSyncDatabaseAction extends ActionBase {
@Nullable private final Pattern includingPattern;
@Nullable private final Pattern excludingPattern;
private final Map<String, String> tableConfig;
+ private final String includingTables;
+ private final List<String> excludedTables;
Review Comment:
excludedTables can be local field in `build`, we can introduce
`getMySqlSchemaList(List<String> excludedTables)`.
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlSyncDatabaseAction.java:
##########
@@ -105,6 +110,10 @@ public class MySqlSyncDatabaseAction extends ActionBase {
@Nullable private final Pattern includingPattern;
Review Comment:
So it should be non-null field? You should modify declarement and invoking
place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
