JingsongLi commented on code in PR #1261:
URL: https://github.com/apache/incubator-paimon/pull/1261#discussion_r1247580165
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlActionUtils.java:
##########
@@ -196,8 +196,8 @@ static MySqlSource<String> buildMySqlSource(Configuration
mySqlConfig) {
.getOptional(MySqlSourceOptions.SERVER_TIME_ZONE)
.ifPresent(sourceBuilder::serverTimeZone);
mySqlConfig
- .getOptional(MySqlSourceOptions.SCAN_SNAPSHOT_FETCH_SIZE)
- .ifPresent(sourceBuilder::fetchSize);
+
.getOptional(MySqlSourceOptions.SCAN_INCREMENTAL_SNAPSHOT_CHUNK_SIZE)
Review Comment:
why modify this?
add comments
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlActionUtils.java:
##########
@@ -210,6 +210,9 @@ static MySqlSource<String> buildMySqlSource(Configuration
mySqlConfig) {
mySqlConfig
.getOptional(MySqlSourceOptions.HEARTBEAT_INTERVAL)
.ifPresent(sourceBuilder::heartbeatInterval);
+ mySqlConfig
+ .getOptional(MySqlSourceOptions.SCAN_NEWLY_ADDED_TABLE_ENABLED)
+ .ifPresent(sourceBuilder::scanNewlyAddedTableEnabled);
Review Comment:
why modify this?
Has `MySqlSourceBuilder.scanNewlyAddedTableEnabled`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
