JingsongLi commented on code in PR #6977:
URL: https://github.com/apache/paimon/pull/6977#discussion_r2671398081
##########
paimon-python/pypaimon/write/file_store_commit.py:
##########
@@ -138,76 +113,49 @@ def overwrite(self, overwrite_partition, commit_messages:
List[CommitMessage], c
self._try_commit(
commit_kind="OVERWRITE",
- commit_entries=None, # Will be generated in _try_commit based on
latest snapshot
- commit_identifier=commit_identifier
+ commit_identifier=commit_identifier,
+ commit_entries_plan=lambda snapshot:
self._generate_overwrite_entries(snapshot)
)
- def _try_commit(self, commit_kind, commit_entries, commit_identifier):
+ def _try_commit(self, commit_kind, commit_identifier, commit_entries_plan):
Review Comment:
`delete_entries_generator, add_entries`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
