leaves12138 commented on code in PR #6977:
URL: https://github.com/apache/paimon/pull/6977#discussion_r2671715749
##########
paimon-python/pypaimon/write/file_store_commit.py:
##########
@@ -190,8 +187,6 @@ def _try_commit(self, commit_kind, commit_entries,
commit_identifier):
def _try_commit_once(self, retry_result: Optional[RetryResult],
commit_kind: str,
commit_entries: List[ManifestEntry],
commit_identifier: int,
latest_snapshot: Optional[Snapshot]) -> CommitResult:
- start_time_ms = int(time.time() * 1000)
-
if retry_result is not None and latest_snapshot is not None:
Review Comment:
OK
##########
paimon-python/pypaimon/write/file_store_commit.py:
##########
@@ -138,11 +137,11 @@ def overwrite(self, overwrite_partition, commit_messages:
List[CommitMessage], c
self._try_commit(
commit_kind="OVERWRITE",
- commit_entries=None, # Will be generated in _try_commit based on
latest snapshot
- commit_identifier=commit_identifier
+ commit_identifier=commit_identifier,
+ commit_entries_plan=lambda snapshot:
self._generate_overwrite_entries(snapshot)
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
