leaves12138 commented on code in PR #6977:
URL: https://github.com/apache/paimon/pull/6977#discussion_r2671835052
##########
paimon-python/pypaimon/write/file_store_commit.py:
##########
@@ -340,14 +304,34 @@ def _try_commit_once(self, retry_result:
Optional[RetryResult], commit_kind: str
)
return SuccessResult()
- def _generate_overwrite_entries(self):
+ def _duplicate_commit(self, retry_result, latest_snapshot,
commit_identifier, commit_kind) -> bool:
+ if retry_result is not None and latest_snapshot is not None:
+ start_check_snapshot_id = 1 # Snapshot.FIRST_SNAPSHOT_ID
+ if retry_result.latest_snapshot is not None:
+ start_check_snapshot_id = retry_result.latest_snapshot.id + 1
+
+ for snapshot_id in range(start_check_snapshot_id,
latest_snapshot.id + 2):
Review Comment:
+1!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]