JingsongLi commented on code in PR #7948:
URL: https://github.com/apache/paimon/pull/7948#discussion_r3295841360
##########
paimon-api/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -3649,7 +3660,10 @@ public boolean forceLookup() {
Review Comment:
**Suggestion: add a helper accessor method**
For consistency with other boolean options (e.g.,
`deletionVectorsEnabled()`, `visibilityCallbackEnabled()`), consider adding a
dedicated accessor method:
```java
public boolean deletionVectorsMergeOnRead() {
return options.get(DELETION_VECTORS_MERGE_ON_READ);
}
```
Then `batchScanSkipLevel0()` can call `deletionVectorsMergeOnRead()` instead
of directly accessing the config, and `SchemaValidation` can also use
`options.deletionVectorsMergeOnRead()` instead of
`options.toConfiguration().get(CoreOptions.DELETION_VECTORS_MERGE_ON_READ)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
