JunRuiLee commented on code in PR #7948:
URL: https://github.com/apache/paimon/pull/7948#discussion_r3297269404
##########
paimon-core/src/main/java/org/apache/paimon/schema/SchemaValidation.java:
##########
@@ -620,6 +624,12 @@ private static void validateForDeletionVectors(CoreOptions
options) {
!options.mergeEngine().equals(MergeEngine.FIRST_ROW),
"First row merge engine does not need deletion vectors
because there is no deletion of old data in this merge engine.");
}
+
+ checkArgument(
+ !(options.deletionVectorsMergeOnRead() &&
options.visibilityCallbackEnabled()),
Review Comment:
Good point. Removed the conflict check. Added positive validation tests and
extended `VisibilityCallbackTest` to cover `(dv=true, postpone=true)` with
`merge-on-read=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
