JingsongLi commented on code in PR #7948:
URL: https://github.com/apache/paimon/pull/7948#discussion_r3295842268
##########
paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/DeletionVectorITCase.java:
##########
@@ -206,6 +206,38 @@ public void testBatchReadDVTable(String changelogProducer,
boolean dvBitmap64) {
Row.of(1, "111111111"), Row.of(2, "2_1"), Row.of(3,
"3_1"), Row.of(4, "4"));
}
+ @ParameterizedTest
+ @MethodSource("parameters1")
+ public void testBatchReadDVTableWithMergeOnRead(String changelogProducer,
boolean dvBitmap64) {
+ sql(
+ String.format(
+ "CREATE TABLE T (id INT PRIMARY KEY NOT ENFORCED, name
STRING) "
+ + "WITH ('deletion-vectors.enabled' = 'true',
'changelog-producer' = '%s', "
+ + "'deletion-vectors.bitmap64' = '%s',
'write-only' = 'true')",
+ changelogProducer, dvBitmap64));
+
+ sql("INSERT INTO T VALUES (1, '111111111'), (2, '2'), (3, '3'), (4,
'4')");
+
+ sql("INSERT INTO T VALUES (2, '2_1'), (3, '3_1')");
+
Review Comment:
**Inconsistency with core test `testDefaultSkipsLevel0`**
The core-level test `DeletionVectorsMergeOnReadTest#testDefaultSkipsLevel0`
asserts an **empty** result when reading without merge-on-read (all files at
level 0, none visible). But this Flink IT test asserts the **first commit's
data is visible** without merge-on-read.
This difference is likely because the core test explicitly sets `bucket=1`
(fixed bucket) while this Flink test doesn't (defaults to dynamic bucket mode,
which may place initial files differently). Could be worth:
1. Adding a brief comment explaining why the first commit's data is visible
here (e.g., files from the first snapshot are at level > 0 in this config), or
2. Aligning the two tests to use the same bucket configuration for
consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
