leaves12138 commented on code in PR #7933:
URL: https://github.com/apache/paimon/pull/7933#discussion_r3323158198


##########
paimon-spark/paimon-spark-common/src/main/java/org/apache/paimon/spark/procedure/CreateGlobalIndexProcedure.java:
##########
@@ -170,7 +198,7 @@ public InternalRow[] call(InternalRow args) {
                     } catch (Exception e) {

Review Comment:
   Nit: this error message uses `column` (the raw comma-separated input string) 
instead of `indexColumns` (the parsed `List<String>`). The Flink procedure uses 
`indexColumns` in its error message — should be consistent.
   
   ```java
   // current
   String.format("Failed to create %s index for columns '%s' on table '%s'.", 
indexType, column, tableIdent)
   // suggested
   String.format("Failed to create %s index for columns '%s' on table '%s'.", 
indexType, indexColumns, tableIdent)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to