leaves12138 commented on PR #8003:
URL: https://github.com/apache/paimon/pull/8003#issuecomment-4560304567
Thanks for the refactor. I don't think this PR is ready to approve yet
because there are a few blockers/inconsistencies to address first.
1. **`paimon-lumina` test compilation fails.**
`LuminaVectorGlobalIndexReader` now requires an `ExecutorService`
constructor argument, but some test/benchmark code still uses the old
constructor signature. I hit this with:
```bash
mvn -pl paimon-spark/paimon-spark-ut -am -Pfast-build -DskipTests
test-compile
```
The failures are in:
-
`paimon-lumina/src/test/java/org/apache/paimon/lumina/index/LuminaVectorGlobalIndexTest.java`
-
`paimon-lumina/src/test/java/org/apache/paimon/lumina/index/LuminaVectorBenchmark.java`
2. **Bitmap global index is removed, but Spark procedure tests still expect
it.**
This PR removes the bitmap global index implementation and its service
registration, leaving only `BTreeGlobalIndexerFactory` in
`META-INF/services/org.apache.paimon.globalindex.GlobalIndexerFactory`.
However, `CreateGlobalIndexProcedureTest` still contains several `index_type =>
'bitmap'` cases. If bitmap global index is intentionally removed, please also
update/remove those tests and mention the compatibility impact in the PR
description/docs. Otherwise, the bitmap factory should be kept.
Minor follow-ups:
- `global-index.thread-num` changes from the previous default of available
processors to a fixed default of `32`; please confirm this behavior change is
intended.
- `GlobalIndexEvaluator` still accepts an `ExecutorService` constructor
argument but no longer uses it.
- `VectorReadImpl` and `FullTextReadImpl` pass `newDirectExecutorService()`
to per-split readers, so the async path may not provide cross-split parallelism
there. If cross-split parallelism is still desired, consider reusing the
configured global-index executor.
For reference, these targeted common tests passed locally:
```bash
mvn -pl paimon-common -Pfast-build
-Dtest=GlobalIndexEvaluatorTest,BTreeThreadSafetyTest,LazyFilteredBTreeIndexReaderTest,BTreeIndexReaderTest,GlobalIndexSerDeUtilsTest
test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
