JingsongLi commented on code in PR #8003:
URL: https://github.com/apache/paimon/pull/8003#discussion_r3316327648
##########
paimon-python/pypaimon/globalindex/tantivy/tantivy_full_text_global_index_reader.py:
##########
@@ -164,37 +163,38 @@ def visit_full_text_search(self, full_text_search) ->
Optional[ScoredGlobalIndex
for row_id, score in zip(row_ids, scores):
id_to_scores[row_id] = score
- return DictBasedScoredIndexResult(id_to_scores)
+ return _completed_future(DictBasedScoredIndexResult(id_to_scores))
Review Comment:
It is indeed a reasonable design: Python GIL restricts true parallelism,
while the asynchronous interface maintains the same API form as the Java side,
which can be replaced with asyncio or thread pool implementation in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
