leaves12138 commented on PR #8003:
URL: https://github.com/apache/paimon/pull/8003#issuecomment-4560450294
Thanks for the update. The previous compilation blockers look fixed to me
now:
- `paimon-lumina` test compilation passes locally with:
```bash
mvn -pl paimon-lumina -am -Pfast-build -DskipTests test-compile
```
- The targeted common tests still pass:
```bash
mvn -pl paimon-common -Pfast-build
-Dtest=GlobalIndexEvaluatorTest,BTreeThreadSafetyTest,LazyFilteredBTreeIndexReaderTest,BTreeIndexReaderTest,GlobalIndexSerDeUtilsTest
test
```
I found one remaining consistency issue around the bitmap removal: the
procedure docs still mention bitmap global index support even though the bitmap
global index implementation and service registration have been removed.
Please update these stale references:
- `docs/docs/spark/procedures.md`: `create_global_index` /
`drop_global_index` still say `btree` or `bitmap`.
- `docs/docs/flink/procedures.md`: `create_global_index` /
`drop_global_index` still list bitmap examples and supported types including
`bitmap`.
- Minor comments also still mention bitmap in `FileType` docs
(`FileType.java` and Python `file_type.py`).
After the docs are aligned with the implementation, this looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
