CrownChu commented on code in PR #7933: URL: https://github.com/apache/paimon/pull/7933#discussion_r3323986361
########## paimon-core/src/main/java/org/apache/paimon/globalindex/GlobalIndexBuilderUtils.java: ########## @@ -24,18 +24,31 @@ import org.apache.paimon.index.GlobalIndexMeta; import org.apache.paimon.index.IndexFileMeta; import org.apache.paimon.index.IndexPathFactory; +import org.apache.paimon.manifest.ManifestEntry; import org.apache.paimon.options.Options; +import org.apache.paimon.schema.SchemaManager; import org.apache.paimon.table.FileStoreTable; import org.apache.paimon.types.DataField; import org.apache.paimon.utils.Range; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import javax.annotation.Nullable; + import java.io.IOException; import java.util.ArrayList; +import java.util.HashMap; import java.util.List; +import java.util.Map; Review Comment: Thanks for catching this! Fixed in IndexManifestFileHandler.validateRetainedIndexFiles(). Split the overlap detection into two branches: - Single-column: keep original indexFieldId comparison - Multi-column (indexFieldId == -1): use Arrays.equals(extraFieldIds) to distinguish different column groups This way two multi-column indexes on different column sets (e.g. [title, vec] vs [content, embedding]) won't trigger false positive overlap errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
