JingsongLi commented on code in PR #7933:
URL: https://github.com/apache/paimon/pull/7933#discussion_r3371948878
##########
paimon-common/src/main/java/org/apache/paimon/globalindex/GlobalIndexerFactory.java:
##########
@@ -22,10 +22,30 @@
import org.apache.paimon.options.Options;
import org.apache.paimon.types.DataField;
+import java.util.List;
+
/** File index factory to construct {@link FileIndexer}. */
public interface GlobalIndexerFactory {
String identifier();
GlobalIndexer create(DataField dataField, Options options);
+
+ /**
+ * Whether this index type supports multi-column indexes. A factory that
returns {@code true}
+ * must override {@link #create(List, Options)} to handle more than one
column.
+ */
+ default boolean supportsMultiColumn() {
+ return false;
+ }
+
+ default GlobalIndexer create(List<DataField> fields, Options options) {
Review Comment:
Can you modify these methods to `extraFields`? Just like:
`default GlobalIndexer create(DataField dataField, List<DataField>
extraFields, Options options)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
