aisk commented on PR #8083:
URL: https://github.com/apache/paimon/pull/8083#issuecomment-4638191724
Hi, thank you for your review.
I checked that although PyRoarning don't have a wheel package for Python3.6,
but it's actually build-able from source and can be used under Python3.6, since
it don't have a `python-requires` filed on it's `setup.py`. The CI have build
it successfully:
```
Building wheels for collected packages: pyroaring
Building wheel for pyroaring (setup.py): started
Building wheel for pyroaring (setup.py): finished with status 'done'
Created wheel for pyroaring:
filename=pyroaring-1.0.0-cp36-cp36m-linux_x86_64.whl size=386841
sha256=29c17f1e9f3224de50f20299149e1eec2b2c51ef20d80a9d92c514b3a8da1283
Stored in directory:
/tmp/pip-ephem-wheel-cache-zowmzlj2/wheels/a9/8e/dd/ced219123113d222e5dbe62e7a7ac640fb1e88ce2ce63af9c5
Successfully built pyroaring
```
I think it's ok to have it on Python3.6. But it's not officially support,
and will introduce some installation issues for users like if they don't have
GCC installed. So I think it's better to drop support for Python3.6 and 3.7,
because they have sunset for a long time.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
