JingsongLi commented on code in PR #8083: URL: https://github.com/apache/paimon/pull/8083#discussion_r3446123287
########## paimon-python/dev/requirements-dev.txt: ########## @@ -15,17 +15,20 @@ # See the License for the specific language governing permissions and # limitations under the License. ################################################################################ -# Core dependencies for pypaimon are in requirements.txt +# Core dependencies for pypaimon +-r requirements.txt # Test dependencies for pypaimon are as follows duckdb==1.3.2 Review Comment: This now makes the dev requirements impossible to install on Python 3.8, even though the package still declares `python_requires=">=3.8"` and the workflow only checks `dev/requirements.txt` on 3.8. `duckdb==1.3.2` has no Python 3.8-compatible distribution; simulating pip resolution with `--python-version 38 --only-binary=:all:` only lists duckdb releases up to 1.2.2 and fails with `No matching distribution found for duckdb==1.3.2`. Please keep the old Python-version marker/fallback for duckdb, or raise the minimum supported Python version to 3.9+ and update the matrix/docs accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
