JingsongLi commented on code in PR #8083: URL: https://github.com/apache/paimon/pull/8083#discussion_r3464856616
########## paimon-python/dev/requirements-dev.txt: ########## @@ -15,17 +15,22 @@ # See the License for the specific language governing permissions and # limitations under the License. ################################################################################ -# Core dependencies for pypaimon are in requirements.txt +# Core dependencies for pypaimon +-r requirements.txt # Test dependencies for pypaimon are as follows -duckdb==1.3.2 +duckdb==1.3.2; python_version >= "3.8" Review Comment: This marker still installs `duckdb==1.3.2` on Python 3.8, but that version has no cp38 distribution. Simulating the CI platform with `pip download duckdb==1.3.2 --only-binary=:all: --python-version 38 --implementation cp --abi cp38 --platform manylinux2014_x86_64` fails with `No matching distribution found` and only lists releases up to 1.2.2. The workflow only resolves `dev/requirements.txt` across Python versions, so this `requirements-dev.txt` regression can slip through until someone tries the 3.8 dev/test environment. Please keep the Python 3.8 fallback, e.g. `duckdb<1.3` for 3.8 and `duckdb==1.3.2` for 3.9+. ########## paimon-python/dev/requirements-dev.txt: ########## @@ -15,17 +15,22 @@ # See the License for the specific language governing permissions and # limitations under the License. ################################################################################ -# Core dependencies for pypaimon are in requirements.txt +# Core dependencies for pypaimon +-r requirements.txt Review Comment: Including `requirements.txt` here changes the Python 3.6 CI/dev install from the old unpinned `pyroaring` source build to `pyroaring<=0.3.3` from `requirements.txt`. That keeps dependency resolution green but leaves the supported 3.6 runtime without `pyroaring.BitMap64`, while `RoaringBitmap64` and the global-index/btree paths still import `BitMap64` unconditionally. Since Python 3.6 is still supported, please either use a 3.6-compatible dependency path that provides `BitMap64` (for example the previous `pyroaring>=1.0.0` source-build path) or add an actual Python 3.6 fallback/feature guard for these paths. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
