JingsongLi commented on code in PR #8083: URL: https://github.com/apache/paimon/pull/8083#discussion_r3485022831
########## paimon-python/dev/requirements-dev.txt: ########## @@ -15,17 +15,24 @@ # See the License for the specific language governing permissions and # limitations under the License. ################################################################################ -# Core dependencies for pypaimon are in requirements.txt +# Core dependencies for pypaimon +-r requirements.txt # Test dependencies for pypaimon are as follows -duckdb==1.3.2 +# duckdb 1.3.2 has no cp38 wheel; Python 3.8 caps at the 1.2.x series. +duckdb<1.3; python_version == "3.8" Review Comment: This still leaves Python 3.7 without any `duckdb` from the shared dev/test requirements. The package and README continue to declare Python 3.6+, and this file is now the common CI/dev install path, but neither of the two duckdb markers matches 3.7. Any Python 3.7 dev/test run that exercises the duckdb-backed read paths (for example `table_read.to_pandas` or system table reads) will fail with a missing dependency. Please include 3.7 in the fallback, e.g. `duckdb<1.3; python_version >= "3.7" and python_version < "3.9"`, or explicitly guard those duckdb-backed tests/features on 3.7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
