JingsongLi commented on code in PR #8374:
URL: https://github.com/apache/paimon/pull/8374#discussion_r3489341669
##########
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/aggregate/FieldNestedUpdateAgg.java:
##########
@@ -243,6 +253,11 @@ private void addNestedRows(
InternalRow row = array.getRow(i, nestedFields);
BinaryRow key = keyProjection.apply(row).copy();
+
+ if (!applyNestedKeyNullStrategy(key)) {
Review Comment:
This applies the new strategy only while merging rows in `agg()`. The
`retract()` path still builds/removes keys with `keyProjection` directly, so
with `nested-key-null-strategy=error` a retraction containing a null nested key
will not throw, and with `ignore` it can still process a null-key retraction
instead of ignoring it. Both `AggregateMergeFunction` and
`PartialUpdateMergeFunction` route retract records through
`FieldAggregator.retract(...)`, so the new option should be enforced there as
well (or explicitly documented/tested as agg-only).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
