PyRSA commented on code in PR #8374:
URL: https://github.com/apache/paimon/pull/8374#discussion_r3503741702
##########
paimon-api/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -2943,6 +2945,13 @@ public List<String> fieldNestedUpdateAggNestedKey(String
fieldName) {
return
Arrays.stream(keyString.split(",")).map(String::trim).collect(Collectors.toList());
}
+ public NestedKeyNullStrategy
fieldNestedUpdateAggNestedKeyNullStrategy(String fieldName) {
+ return options.get(
+ key(FIELDS_PREFIX + "." + fieldName + "." +
NESTED_KEY_NULL_STRATEGY)
+ .enumType(NestedKeyNullStrategy.class)
+ .noDefaultValue());
Review Comment:
Thanks for the suggestion! I originally avoided a default value because I
wanted to distinguish between an unspecified option and an explicitly
configured `MERGE`, so that I could validate that `nested-key-null-strategy` is
only configured when `nested-key` is present. With a default value, these two
cases become indistinguishable. The default behavior is still preserved by
falling back to `MERGE` in `FieldNestedUpdateAgg`.
I'm happy to adjust this if you think consistency with other options is more
important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
