PyRSA commented on code in PR #8374:
URL: https://github.com/apache/paimon/pull/8374#discussion_r3490057411
##########
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/aggregate/FieldNestedUpdateAgg.java:
##########
@@ -243,6 +253,11 @@ private void addNestedRows(
InternalRow row = array.getRow(i, nestedFields);
BinaryRow key = keyProjection.apply(row).copy();
+
+ if (!applyNestedKeyNullStrategy(key)) {
Review Comment:
Thanks for catching this! I've updated FieldNestedUpdateAgg.retract() to
apply nested-key-null-strategy consistently when both rebuilding the
accumulator map and processing retract records. I also added corresponding test
cases covering the IGNORE and ERROR behaviors for the retract path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
