QuakeWang commented on code in PR #487:
URL: https://github.com/apache/paimon-rust/pull/487#discussion_r3544696037
##########
crates/paimon/src/table/mod.rs:
##########
@@ -219,8 +222,8 @@ impl Table {
BTreeGlobalIndexBuildBuilder::new(self)
}
- pub fn new_btree_global_index_drop_builder(&self) ->
BTreeGlobalIndexDropBuilder<'_> {
- BTreeGlobalIndexDropBuilder::new(self)
+ pub fn new_global_index_drop_builder(&self) -> GlobalIndexDropBuilder<'_> {
Review Comment:
This renames the public drop builder API and removes the existing
`Table::new_btree_global_index_drop_builder()` entry point. Since
`paimon::table` is public, downstream users calling the old API will fail to
compile. Could we keep a deprecated forwarding method, and optionally a
deprecated `BTreeGlobalIndexDropBuilder` type alias to
`GlobalIndexDropBuilder`, while introducing the generalized API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
