JunRuiLee commented on code in PR #487:
URL: https://github.com/apache/paimon-rust/pull/487#discussion_r3544767811
##########
crates/paimon/src/table/mod.rs:
##########
@@ -219,8 +222,8 @@ impl Table {
BTreeGlobalIndexBuildBuilder::new(self)
}
- pub fn new_btree_global_index_drop_builder(&self) ->
BTreeGlobalIndexDropBuilder<'_> {
- BTreeGlobalIndexDropBuilder::new(self)
+ pub fn new_global_index_drop_builder(&self) -> GlobalIndexDropBuilder<'_> {
Review Comment:
`new_btree_global_index_drop_builder` and `BTreeGlobalIndexDropBuilder` were
introduced in #472, which merged after the v0.2.0 release and isn't part of any
published crates.io release — the latest published `paimon` is 0.2.0. So this
API has never shipped in a release, and no downstream crate can depend on it;
renaming it here isn't a breaking change against any released version, only a
change to unreleased, main-only API.
Given that, I'd prefer the clean rename over a deprecated forwarding method
+ alias, which would be permanent shims for a compatibility guarantee we don't
owe pre-release. If the project would rather keep deprecated aliases as policy
even for unreleased APIs, I'm happy to add them — just let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
