QuakeWang commented on code in PR #487:
URL: https://github.com/apache/paimon-rust/pull/487#discussion_r3544796433
##########
crates/paimon/src/table/mod.rs:
##########
@@ -219,8 +222,8 @@ impl Table {
BTreeGlobalIndexBuildBuilder::new(self)
}
- pub fn new_btree_global_index_drop_builder(&self) ->
BTreeGlobalIndexDropBuilder<'_> {
- BTreeGlobalIndexDropBuilder::new(self)
+ pub fn new_global_index_drop_builder(&self) -> GlobalIndexDropBuilder<'_> {
Review Comment:
That makes sense, thanks for clarifying. I missed that this API has not been
included in any published release yet. In that case I agree this is not a
breaking change against released users, and the clean rename is preferable here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
